integrates caveat context in PermissionService API methods #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api v1
vroldanbet
force-pushed
the
add-permission-service-context
branch
from
8f3d3b8
to
c920bf4
Compare
vroldanbet
force-pushed
the
add-permission-service-context
branch
2 times, most recently
from
d8c3a1f
to
a109547
Compare
github-actions
bot
added
the
area/tooling
vroldanbet
force-pushed
the
add-permission-service-context
branch
from
a109547
to
72facd0
Compare
vroldanbet
changed the title
vroldanbet
commented
Oct 6, 2022
| @@ -112,7 +111,7 @@ func (cl *ConcurrentLookup) LookupViaReachability(ctx context.Context, req Valid | |||
| Metadata: req.Metadata, | |||
| }, stream) | |||
| if err != nil { | |||
| resp := lookupResultError(NewErrInvalidArgument(fmt.Errorf("error in reachablility: %w", err)), emptyMetadata) | |||
| resp := lookupResultError(err, emptyMetadata) | |||
There was a problem hiding this comment.
this was turning every error received by reachable resources into an invalid argument, and prevented downstream code to provide a more specific error code. It also made the assumption everything fell in that category, whereas other error handling in this method did not make such assumption. Therefore it seemed uncontroversial to remove this.
| @@ -111,6 +111,9 @@ func (cl *ConcurrentLookupSubjects) lookupDirectSubjects( | |||
| if it.Err() != nil { | |||
| return it.Err() | |||
| } | |||
| if tpl.Caveat != nil { | |||
There was a problem hiding this comment.
choke point to prevent evaluation of the graph if relationship is caveated. This is a temporal measure until caveat support is introduced in Lookup* methods
vroldanbet
force-pushed
the
add-permission-service-context
branch
from
72facd0
to
e417f4a
Compare
josephschorr
reviewed
Oct 6, 2022
vroldanbet
force-pushed
the
add-permission-service-context
branch
6 times, most recently
from
45f88f5
to
72b3cff
Compare
vroldanbet
force-pushed
the
add-permission-service-context
branch
4 times, most recently
from
ba79cbd
to
3168732
Compare
vroldanbet
force-pushed
the
add-permission-service-context
branch
from
3168732
to
1a16604
Compare
- fully implemented in Check API, new permissionship value "conditional" returned if fields were missing in context - LookupResources and LookupSubjects return errors when a caveated relationship is detected in the working set - a limit of 4096 bytes in the caveat context was introduced. Eventually we can turn this into a configurable setting
vroldanbet
force-pushed
the
add-permission-service-context
branch
from
1a16604
to
97069de
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #881
Closes #882
Closes #880
What
integrates caveat context in PermissionService API methods
How
4096bytes in the caveat context was introduced. Eventually we can turn that into a configurable parameterPERMISSIONSHIP_CONDITIONAL_PERMISSIONresponse, and the response will contain missing fieldsLookupSubjectsandLookupResourcesare adjusted to return a gRPC unimplemented error. Various choke points where added to prevent evaluation of caveated relationships in the graph