Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the max size exceeded error public #2049

Merged
merged 1 commit into from
Aug 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/datastore/common/changes.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ func (ch *Changes[R, K]) adjustByteSize(item sized, delta int) error {
}

if ch.currentByteSize > int64(ch.maxByteSize) {
return NewMaximumChangesSizeExceededError(ch.maxByteSize)
return datastore.NewMaximumChangesSizeExceededError(ch.maxByteSize)
}

return nil
Expand Down
11 changes: 0 additions & 11 deletions internal/datastore/common/errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -153,14 +153,3 @@ type RevisionUnavailableError struct {
func NewRevisionUnavailableError(err error) error {
return RevisionUnavailableError{err}
}

// MaximumChangesSizeExceededError is returned when the maximum size of changes is exceeded.
type MaximumChangesSizeExceededError struct {
error
maxSize uint64
}

// NewMaximumChangesSizeExceededError creates a new MaximumChangesSizeExceededError.
func NewMaximumChangesSizeExceededError(maxSize uint64) error {
return MaximumChangesSizeExceededError{fmt.Errorf("maximum changes byte size of %d exceeded", maxSize), maxSize}
}
11 changes: 11 additions & 0 deletions pkg/datastore/errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,17 @@ func (err ErrCounterAlreadyRegistered) DetailsMetadata() map[string]string {
}
}

// MaximumChangesSizeExceededError is returned when the maximum size of changes is exceeded.
type MaximumChangesSizeExceededError struct {
error
maxSize uint64
}

// NewMaximumChangesSizeExceededError creates a new MaximumChangesSizeExceededError.
func NewMaximumChangesSizeExceededError(maxSize uint64) error {
return MaximumChangesSizeExceededError{fmt.Errorf("maximum changes byte size of %d exceeded", maxSize), maxSize}
}

var (
ErrClosedIterator = errors.New("unable to iterate: iterator closed")
ErrCursorsWithoutSorting = errors.New("cursors are disabled on unsorted results")
Expand Down
Loading