Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurable max buffer size for watch change tracker #2044

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Add configurable max buffer size for watch change tracker #2044

merged 1 commit into from
Aug 30, 2024

Conversation

josephschorr
Copy link
Member

No description provided.

@josephschorr josephschorr requested review from vroldanbet and a team as code owners August 28, 2024 04:12
@github-actions github-actions bot added area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Aug 28, 2024
vroldanbet
vroldanbet requested changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea should help, but I'd suggest making this easier to tune and ideally a setting that one rarely has to change.

internal/datastore/common/changes.go Outdated Show resolved Hide resolved
vroldanbet
vroldanbet approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks for addressing the feedback!

@vroldanbet vroldanbet added this pull request to the merge queue Aug 30, 2024
Merged via the queue into authzed:main with commit c237aa2 Aug 30, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vroldanbet vroldanbet vroldanbet approved these changes

Assignees
No one assigned
Labels
area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephschorr @vroldanbet