Check data structure improvements #2037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/tooling
josephschorr
force-pushed
the
check-improvements
branch
from
777c226
to
76bbcbf
Compare
tstirrat15
previously approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Are there there any meaningful changes between this and the deleted file?
| @@ -100,9 +100,7 @@ func (tss *TrackingSubjectSet) getSetForKey(key string) datasets.BaseSubjectSet[ | |||
| fs.excludedSubjects = excludedSubjects | |||
| fs.caveatExpression = caveatExpression | |||
| for _, source := range sources { | |||
| if source.relationships != nil { | |||
There was a problem hiding this comment.
Why isn't this check necessary anymore?
There was a problem hiding this comment.
I moved it into the set impl
| return iHasCaveat && !jHasCaveat | ||
| }) | ||
|
|
||
| chunkCount := 0.0 |
There was a problem hiding this comment.
The float here surprises me - is that intentional?
There was a problem hiding this comment.
Yes; we use it for the Prometheus metric below
vroldanbet
reviewed
Sep 2, 2024
This new set does all the tracking and mapping previously handled by the ONRTypeSet and a custom multimap, in a more compact and better tested implementation This also allows us to avoid requiring all results for those redispatches that do not have caveats, even if one of the subject types does
josephschorr
force-pushed
the
check-improvements
branch
from
76bbcbf
to
bb10dfe
Compare
|
Updated |
vroldanbet
approved these changes
Sep 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves around and cleans up some data structures used in check