Fix logging behavior around setting goproc limits #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstirrat15
force-pushed
the
2010-fix-logging-behavior
branch
from
7b1d4a4
to
14a0ee6
Compare
alecmerdler
reviewed
Aug 12, 2024
pkg/cmd/limits/limits.go
Outdated
| // SetLimitsRunE wraps the RunFunc with setup logic for memory limits and maxprocs | ||
| // limits for the go process. Implementing it here means that we can use already- | ||
| // established loggers and wrap only those commands that require it. | ||
| func SetLimitsRunE() cobrautil.CobraRunFunc { |
There was a problem hiding this comment.
This seems useful enough to put into cobrautil so it can be used across other projects.
alecmerdler
reviewed
Aug 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2010
Description
In the implementation of #1921, we added memory and proc limits at the top level, along with logging from those libraries. Because it sits above the level of any of the commands, it didn't respect log levels. This fixes it by moving it into a
PreRunEwrapper that sits below the level of log setup, which also means that it will be correctly formatted when running from the command line, and also only apply to commands that need it (we probably don't need it onversion, for example).Notes
@ecordell made the point that this would probably be useful in Materialize as well; if it's desired, we can push this up into
cobrautiland pull it into both projects that way.Questions
Changes
RunEfunctionRunEfunction in theDefaultPreRunEfunctionTesting
See that
spicedb versionno longer reports changes from the limit libraries. See that if you set--log-level debug, you see output related to these libs nicely-formatted early in the output ofspicedb serveand friends.