Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump Docker to address security scanners surfacing CVE #2004

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

vroldanbet
Copy link
Contributor

this was a more elaborate change that I anticipated. bumping docker forced me to bump buf tooling.

Changes to generate proto seems expected, but
the "buf format" tool changed dramatically:

  • does no longer accept running on a directory outside of the context directory. This is not a trivial change because it forces us to move all dependencies to the main go.mod, including buf and all proto generators
  • removes commas outside of proto definition, unclear if thats valid proto or a bug on the format tool

this was a more elaborate change that I anticipated.
bumping docker forced me to bump buf tooling.

Changes to generate proto seems expected, but
the  "buf format" tool changed dramatically:
- does no longer accept running on a directory
  outside of the context directory. This is not a trivial
  change because it forces us to move all dependencies
  to the main go.mod, including buf and all proto generators
- removes commas outside of proto definition, unclear if thats
  valid proto or a bug on the format tool
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vroldanbet vroldanbet added this pull request to the merge queue Jul 30, 2024
Merged via the queue into main with commit 567d33f Jul 30, 2024
22 checks passed
@vroldanbet vroldanbet deleted the docker-cve-2 branch July 30, 2024 16:50
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/dependencies Affects dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants