Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust pg revision timestamps #1972

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

vroldanbet
Copy link
Contributor

two follow up changes to #1951

  • the unit is nanos, to align it with the resolution of the inexact float64 provided by the CRDB HCL revision
  • also provide timestamp and transaction ID values with checkpoint revisions, which were not being delivered via the Datastore Watch API

@vroldanbet vroldanbet requested a review from a team as a code owner July 4, 2024 17:48
@github-actions github-actions bot added area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Jul 4, 2024
two follow up changes to #1951
- the unit is nanos, to align it with the resolution
  of the inexact float64 provided by the CRDB HCL revision
- also provide timestamp and transaction ID values with
  checkpoint revisions, which were not being delivered
  via the Datastore Watch API
@vroldanbet vroldanbet force-pushed the align-revision-timestamps-crdb-pg branch from 3ace78b to 36d8b12 Compare July 4, 2024 17:54
@vroldanbet vroldanbet enabled auto-merge July 4, 2024 17:55
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vroldanbet vroldanbet added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit 4891cfb Jul 4, 2024
22 checks passed
@vroldanbet vroldanbet deleted the align-revision-timestamps-crdb-pg branch July 4, 2024 18:26
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants