enables prometheus exemplars support #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enabling exemplars makes possible to correlate traces with a metric. Clients scraping will be able to do content negotiation and request OpenMetrics format. This change is not innocuous: prometheus defaults to scraping with OpenMetrics format, and as a result the "le" labels of histograms will have a trailing zero. From the prometheus/client_golang docs // If true, the experimental OpenMetrics encoding is added to the // possible options during content negotiation. Note that Prometheus // 2.5.0+ will negotiate OpenMetrics as first priority. OpenMetrics is // the only way to transmit exemplars. However, the move to OpenMetrics // is not completely transparent. Most notably, the values of "quantile" // labels of Summaries and "le" labels of Histograms are formatted with // a trailing ".0" if they would otherwise look like integer numbers // (which changes the identity of the resulting series on the Prometheus // server).
vroldanbet
changed the title
github-actions
bot
added
area/CLI
alecmerdler
approved these changes
Feb 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enabling exemplars makes possible to correlate
traces with a metric. Clients scraping will be
able to do content negotiation and request
OpenMetrics format.
This change is not innocuous: prometheus defaults
to scraping with OpenMetrics format, and as a result the "le" labels of histograms will have a trailing zero. From the prometheus/client_golang docs