re-enable gosec/G404 #1757
Merged
re-enable gosec/G404 #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api v1
vroldanbet
force-pushed
the
replace-math-rand
branch
2 times, most recently
from
7923ee8
to
5878479
Compare
replaces the generator using math/rand with rs/xid Benchmarked current vs google UUID vs rs/xid BenchmarkUUID-12 475.9 ns/op 64 B/op 2 allocs/op BenchmarkMathRand-12 397.4 ns/op 176 B/op 2 allocs/op BenchmarkXid-12 55.03 ns/op 24 B/op 1 allocs/op xid is not cryptographically secure, but guarantees 16,777,216 unique values per second and per host/process. That number seems higher than we expect a single SpiceDB process to handle in terms of requests per second.
after updating the golanci-lint action to the latest version, revive is flagging a lot of "unused-parameter" and is very annoying
all these uses to do not have security concerns, and math rand is used because contention of crypto/rand can hurt throughput/latency on the critical path.
vroldanbet
force-pushed
the
replace-math-rand
branch
2 times, most recently
from
4c0738d
to
2bc5d90
Compare
jzelinskie
approved these changes
Feb 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enables gosec/G404 to detect usages of cryptographically unsafe
math/rand, and goes over all the usages, and removes when it makes sense, or adds a// nolintdirective with a justification when it does not.