reduces chunking allocations for wide relations #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vroldanbet
force-pushed
the
reduce-allocations-for-wide-relations
branch
from
6c0b580
to
31defe5
Compare
jzelinskie
reviewed
Feb 21, 2024
jzelinskie
added
area/perf
vroldanbet
force-pushed
the
reduce-allocations-for-wide-relations
branch
from
31defe5
to
193c618
Compare
vroldanbet
requested review from
jzelinskie
and removed request for
josephschorr
internal/graph/check.go
Outdated
| @@ -383,7 +383,10 @@ func (cc *ConcurrentChecker) checkDirect(ctx context.Context, crc currentRequest | |||
| it.Close() | |||
|
|
|||
| // Convert the subjects into batched requests. | |||
| toDispatch := make([]directDispatch, 0, subjectsToDispatch.Len()) | |||
| // To simplify the logic, +1 is added to account for the situation | |||
internal/graph/check.go
Outdated
| @@ -601,7 +604,10 @@ func (cc *ConcurrentChecker) checkTupleToUserset(ctx context.Context, crc curren | |||
| it.Close() | |||
|
|
|||
| // Convert the subjects into batched requests. | |||
| toDispatch := make([]directDispatch, 0, subjectsToDispatch.Len()) | |||
| // To simplify the logic, +1 is added to account for the situation | |||
For most situations, when the number of elements to dispatch is below the default 100 elements, the slice with elements to dispatch was appropriately pre-allocated. However, when dispatching large number of elements, the silence will grow from 1 up to the number of chunks, causing wasteful allocations in the critical path. To simplify the logic, +1 is added to account for the situation the number of elements is less than the chunk size. For values above that it will cause one excess slice entry allocation, but seems like a reasonable tradeoff w.r.t extra annoying code to handle it.
vroldanbet
force-pushed
the
reduce-allocations-for-wide-relations
branch
from
193c618
to
1d46c13
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For most situations, when the number of elements to dispatch is below the default 100 elements, the slice with elements to dispatch was appropriately pre-allocated.
However, when dispatching large number of elements, the silence will grow from 1 up to the number of chunks, causing wasteful allocations in the critical path.
To simplify the logic, +1 is added to account for the situation the number of elements is less than the chunk size. For values above that it will cause one excess slice entry allocation, but seems like a reasonable tradeoff w.r.t extra annoying code to handle it.