fix broken v1alpha gRPC reflection support #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vroldanbet
force-pushed
the
fix-grpc-reflection
branch
from
618e8b1
to
291366e
Compare
bison
previously approved these changes
Jan 23, 2024
with the introduction of v1 Reflection, `grpcutil` was updated in a way that broke `v1alpha` reflection calls. The go-grpc ecosystem continues to support both versions, and the handler for v1alpha was being in fact registered, but the authless wrapper exposed by `grpcutil` was failing to bypass auth for `v1alpha` calls because it dropped support for it. This vendors the changes to `grpcutil` that introduce back `v1alpha` support, and also addresses a missing allowlist in the consistency middleware for `v1` version.
vroldanbet
force-pushed
the
fix-grpc-reflection
branch
from
291366e
to
d2d874f
Compare
jzelinskie
approved these changes
Jan 24, 2024
jzelinskie
added
kind/tech debt
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes gRPC reflection support for clients like Postman
with the introduction of v1 Reflection,
grpcutilwas updated in a way that brokev1alphareflection calls.grpc-gocontinues to support both versions and the handler forv1alphawas being registered, but the authless wrapper exposed bygrpcutilwas failing to bypass auth forv1alphacalls because it dropped support for it.This vendors the changes to
grpcutilthat introduce backv1alphasupport, and also addresses a missing allowlist in the consistency middleware for thev1version.