Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add OTEL tracing to pgx Queries #1449

Merged
merged 2 commits into from
Jul 27, 2023
Merged

add OTEL tracing to pgx Queries #1449

merged 2 commits into from
Jul 27, 2023

Conversation

vroldanbet
Copy link
Contributor

@vroldanbet vroldanbet commented Jul 19, 2023 •
edited
Loading

From pgx v5 it became possible to add arbitrary
tracers to PGX. This commit introduces a composed
tracer so we can have both the Logging tracer
and the new PGX tracer based on
github.com/exaring/otelpgx

example of a WriteRelationships call

image

example of a CheckPermission call

image

@vroldanbet vroldanbet requested a review from a team as a code owner July 19, 2023 12:10
@github-actions github-actions bot added area/datastore Affects the storage system area/dependencies Affects dependencies labels Jul 19, 2023
@vroldanbet vroldanbet self-assigned this Jul 19, 2023
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Jul 26, 2023
@vroldanbet
add OTEL tracing to pgx Queries
1b31d8c 
From pgx v5 it became possible to add arbitrary
tracers to PGX. This commit introduces a composed
tracer so we can have both the Logging tracer
and the new PGX tracer based on
github.com/exaring/otelpgx
@vroldanbet
Copy link
Contributor Author

@josephschorr added test, PTAL 🙏🏻

josephschorr
josephschorr approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vroldanbet vroldanbet added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit 55d4ccc Jul 27, 2023
25 checks passed
@vroldanbet vroldanbet deleted the add-pgx-otel-tracing branch July 27, 2023 16:32
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephschorr josephschorr josephschorr approved these changes

Assignees

@vroldanbet vroldanbet

Labels
area/datastore Affects the storage system area/dependencies Affects dependencies area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vroldanbet @josephschorr