adds a lint:trivy command to mage #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I haven't added it as part of the lint:all command since it takes a bit to run I've also added a new alias "scan" which runs security scanning tools
ecordell
reviewed
Jul 18, 2023
| func (l Lint) Trivy() error { | ||
| mg.Deps(Build{}.Testimage) | ||
| fmt.Println("running Trivy container scan") | ||
| return sh.RunV("docker", "run", "-v", "/var/run/docker.sock:/var/run/docker.sock", "aquasec/trivy:latest", "image", "--format", "table", "--exit-code", "1", "--ignore-unfixed", "--vuln-type", "os,library", "--no-progress", "--severity", "CRITICAL,HIGH,MEDIUM", "authzed/spicedb:ci") |
There was a problem hiding this comment.
Since trivy is a go project, I think we could manage it as a tool and just run with go run github.com/aquasecurity/trivy/cmd/trivy/main.go?
There was a problem hiding this comment.
Ah I guess we haven't made these magefiles a separate go module yet like we have in some other projects. This LGTM then and we can revisit later.
ecordell
approved these changes
Jul 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't added it as part of the lint:all
command since it takes a bit to run
I've also added a new alias "scan" which
runs security scanning tools