fixes incorrect usage of backoff in GC #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vroldanbet Can we add a test for this somehow? Perhaps initializing the GC with settings that get it to reproduce the old behavior? |
once `MaxElapsedTime` has elapsed, the backoff switches to the value of `Stop` which is -1. This mean it will effectively remove the backoff and a storm of requests will hit the DB. I also changed it in every instance I found because the default behaviour is dangerous. See #1444
github-actions
bot
added
the
area/tooling
|
@josephschorr done, please have a look |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1444
once
MaxElapsedTimehas elapsed, the backoff switches to the value ofStopwhich is -1. This means itwill effectively remove the backoff and a storm of requests will hit the DB.
I also changed it in every instance I found because the default behaviour is dangerous.