Skip to content

Commit

Permalink
Make the max size exceeded error public
Browse files Browse the repository at this point in the history
  • Loading branch information
josephschorr committed Aug 30, 2024
1 parent 506248a commit b632f8d
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion internal/datastore/common/changes.go
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ func (ch *Changes[R, K]) adjustByteSize(item sized, delta int) error {
}

if ch.currentByteSize > int64(ch.maxByteSize) {
return NewMaximumChangesSizeExceededError(ch.maxByteSize)
return datastore.NewMaximumChangesSizeExceededError(ch.maxByteSize)
}

return nil
Expand Down
11 changes: 0 additions & 11 deletions internal/datastore/common/errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -153,14 +153,3 @@ type RevisionUnavailableError struct {
func NewRevisionUnavailableError(err error) error {
return RevisionUnavailableError{err}
}

// MaximumChangesSizeExceededError is returned when the maximum size of changes is exceeded.
type MaximumChangesSizeExceededError struct {
error
maxSize uint64
}

// NewMaximumChangesSizeExceededError creates a new MaximumChangesSizeExceededError.
func NewMaximumChangesSizeExceededError(maxSize uint64) error {
return MaximumChangesSizeExceededError{fmt.Errorf("maximum changes byte size of %d exceeded", maxSize), maxSize}
}
11 changes: 11 additions & 0 deletions pkg/datastore/errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,17 @@ func (err ErrCounterAlreadyRegistered) DetailsMetadata() map[string]string {
}
}

// MaximumChangesSizeExceededError is returned when the maximum size of changes is exceeded.
type MaximumChangesSizeExceededError struct {
error
maxSize uint64
}

// NewMaximumChangesSizeExceededError creates a new MaximumChangesSizeExceededError.
func NewMaximumChangesSizeExceededError(maxSize uint64) error {
return MaximumChangesSizeExceededError{fmt.Errorf("maximum changes byte size of %d exceeded", maxSize), maxSize}
}

var (
ErrClosedIterator = errors.New("unable to iterate: iterator closed")
ErrCursorsWithoutSorting = errors.New("cursors are disabled on unsorted results")
Expand Down

0 comments on commit b632f8d

Please sign in to comment.