Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC integration contributions docs: Seafile (update) and Roundcube (new) #6195

Merged
merged 6 commits into from
Nov 14, 2023

Conversation

sphakka
Copy link
Contributor

@sphakka sphakka commented Oct 26, 2023

Only documentation for OIDC integration is affected:

  • Improved Seafile docs
  • New Roundcube (+ Dovecot, Postfix) docs.

@authelia
Copy link

authelia bot commented Oct 26, 2023

Thanks for choosing to contribute @sphakka. We lint all PR's with golangci-lint and eslint, I may add a review to your PR with some suggestions.

You are free to apply the changes if you're comfortable, alternatively you are welcome to ask a team member for advice.

Artifacts

These changes once approved by a team member will be published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:PR6195
  • docker pull ghcr.io/authelia/authelia:PR6195

@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit 24d665d
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/6553e7d443872f00089a56fc
😎 Deploy Preview https://deploy-preview-6195--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sphakka
Copy link
Contributor Author

sphakka commented Oct 26, 2023

Err, apparently GitHub doesn't like commits signed externally with my personal key :-(

@james-d-elliott
Copy link
Member

I think you need to add the public key to the account but it should be fine as is. I will look at it as I get some time this week.

Tested on latest stable Authelia and Seafile. Added extra info for SSO auth bypass when using Seafile WebDAV extension with nginx.

Signed-off-by: Marco Emilio "sphakka" Poleggi <[email protected]>
Full stack configuration Roundcube via Nginx, Dovecot and Postfix.

Signed-off-by: Marco Emilio "sphakka" Poleggi <[email protected]>
FIxed typos.

Signed-off-by: Marco Emilio Poleggi <[email protected]>
Fixed bad formatting.

Signed-off-by: Marco Emilio Poleggi <[email protected]>
Copy link
Member

@james-d-elliott james-d-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate the PR! Mostly LGTM, few changes though. Let me know what you think.

Removed Nginx snippets as latest docs provide all needed info.
Reworked doc structure to start with Authelia, then all other configurations.

Signed-off-by: Marco Emilio "sphakka" Poleggi <[email protected]>
@sphakka
Copy link
Contributor Author

sphakka commented Nov 14, 2023

It should be better now ^^

Copy link
Member

@james-d-elliott james-d-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james-d-elliott james-d-elliott enabled auto-merge (squash) November 14, 2023 21:34
@james-d-elliott james-d-elliott merged commit a72b3f7 into authelia:master Nov 14, 2023
10 of 11 checks passed
@sphakka sphakka deleted the docs/web/oidc/contrib branch November 15, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants