Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: "multi" support for SocketConnector.serverToSocket #9

Merged
merged 9 commits into from
Feb 15, 2024
Merged

Conversation

gkc
Copy link
Contributor

@gkc gkc commented Feb 13, 2024

- What I did

  • Added multi parameter to SocketConnector.serverToSocket - whether to create new connections on the "B" side every time there is a new "A" side connection to the bound server port.
  • Also added onConnect parameter, so that callers can be informed when every new connection is made, and can thus take whatever action they need to.
  • feat: Added grace period so that SocketConnector doesn't close until both
    (a) initial timeout has expired and (b) number of established connections
    is zero or has dropped to zero
  • build: updated version and CHANGELOG for v2.1.0
  • test: added tests for multi feature

- How to verify it
Tests pass

…hether to

  create new connections on the "B" side every time there is a new "A" side
  connection to the bound server port. Also added `onConnect` parameter,
  so that callers can be informed when every new connection is made, and
  can thus take whatever action they require.
build: updated version and CHANGELOG for v2.1.0
@gkc gkc changed the title feat: feat: "multi" support for SocketConnector.serverToSocket Feb 13, 2024
@gkc gkc requested a review from cconstab February 13, 2024 17:27
@gkc gkc merged commit e01c958 into trunk Feb 15, 2024
2 checks passed
@gkc
Copy link
Contributor Author

gkc commented Feb 15, 2024

Published v2.1.0 to pub.dev

@gkc gkc deleted the feat/multi branch February 15, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants