feat: add optional param encryptValue to notify method #1391
Conversation
| @@ -93,6 +93,7 @@ abstract class NotificationService { | |||
| true, // this was the behaviour before introducing this parameter | |||
| bool checkForFinalDeliveryStatus = | |||
| true, // this was the behaviour before introducing this parameter | |||
| bool encryptValue = true, | |||
There was a problem hiding this comment.
please add the comment // this was the behaviour before introducing this parameter
| @@ -319,6 +319,7 @@ class NotificationServiceImpl | |||
| true, // this was the behaviour before introducing this parameter | |||
| bool checkForFinalDeliveryStatus = | |||
| true, // this was the behaviour before introducing this parameter | |||
| bool encryptValue = true, | |||
There was a problem hiding this comment.
please add the comment // this was the behaviour before introducing this parameter
There was a problem hiding this comment.
Looks good @murali-shris - can you please add an e2e test also?
sure Gary |
done |
| print(notificationListJson); | ||
| expect(notificationListJson[0]['from'], currentAtSign); | ||
| expect(notificationListJson[0]['to'], sharedWithAtSign); | ||
| expect(notificationListJson[0]['value'], value); |
There was a problem hiding this comment.
can you also add an expect for isEncrypted please?
There was a problem hiding this comment.
I am getting isEncrypted=true for this test.
[{id: 79a2d96e-ff34-442c-aac0-97a556fcbcfc, from: @ce2e1, to: @ce2e2, key: @ce2e2:phone2a9c23ff-cb4c-4d41-a50d-276d87d24820.e2e_test@ce2e1, value: +1 100 200 30, operation: update, epochMillis: 1726120153595, messageType: MessageType.key, isEncrypted: true, metadata: {encKeyName: null, encAlgo: null, ivNonce: null, skeEncKeyName: null, skeEncAlgo: null, availableAt: null, expiresAt: 2024-09-13 05:49:13.595Z***]
Is this because we don't have the changes on the server yet?
Fixed #1390
- What I did
- How I did it
- How to verify it
Test atclient notify change at_libraries#659
Test at commons notify noports#1348