Use pyproject.toml for package metadata #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we can, and should, eventually switch to flit -- because flit is faster and stricter, and because it catches more mistakes such as when you build packages on a source tree with uncommitted changes. But I have painted myself into a corner by the module naming convention "src/sdx/datamodel" rather than "src/sdxdatamodel". Flit expects the the top-level module name to follow project name. Setuptools is a little more forgiving, so using setuptools as build backend for now will help us make progress. Flit's strictness here is better because it also makes sure that editable installs will continue to work. With the former module naming scheme, we have "src/sdx/datamodel" here, and "src/sdx/pce" in pce, and because of that, we can't have editable installs in pce...
Copied over from setup.cfg and converted to toml.
Closed
Closed
|
Does the README need to be updated? |
No. README doesn't assume any build frontend or backend or a style of metadata specification. |
|
I mean, README could be updated, but not in relation to this PR. :-) |
YufengXin
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #45. Moves contents of
setup.pyandsetup.cfgintopyproject.toml. Uses setuptools as the build backend.I would like to use flit as the build backend eventually, because flit is faster and stricter and seems to be able to catch some mistakes in packaging, but that will require more changes such as #96.