Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make package version dynamic #114

Merged
merged 8 commits into from
Jan 11, 2024
Merged

Make package version dynamic #114

merged 8 commits into from
Jan 11, 2024

Conversation

sajith
Copy link
Member

@sajith sajith commented Jan 11, 2024

Minor maintenance changes:

  • Configure package version using setuptools_scm, which is what we do in pce also.
  • Add linting tools as an optional dependency in pyproject.toml.
  • Install linting tools on CI using the above optional dependency.

@sajith sajith self-assigned this Jan 11, 2024
@sajith sajith marked this pull request as draft January 11, 2024 20:12
@coveralls
Copy link

coveralls commented Jan 11, 2024

Pull Request Test Coverage Report for Build 7495140952

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 74.352%

Totals Coverage Status
Change from base Build 7464913947: -0.5%
Covered Lines: 1013
Relevant Lines: 1234

💛 - Coveralls

@sajith sajith marked this pull request as ready for review January 11, 2024 20:18
YufengXin
YufengXin previously approved these changes Jan 11, 2024
Copy link
Collaborator

@YufengXin YufengXin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add yourself to the author block, to be blamed-:)

@sajith
Copy link
Member Author

sajith commented Jan 11, 2024

Please add yourself to the author block, to be blamed-:)

Got me. Was hoping to stay clear of responsibility. ;-)

@sajith sajith requested a review from YufengXin January 11, 2024 21:56
@sajith
Copy link
Member Author

sajith commented Jan 11, 2024

@YufengXin This repository was set up such that new commits to PR branches will mark old approvals as stale. (I have changed it, although I'm of two minds about it.)

Could you please review this again?

That line doesn't really do anything, it turns out
@sajith sajith merged commit 2e81029 into main Jan 11, 2024
11 checks passed
@sajith sajith deleted the dynamic-version branch January 11, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

4 participants