Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in Topology model #111

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Fix typos in Topology model #111

merged 3 commits into from
Sep 26, 2023

Conversation

sajith
Copy link
Member

@sajith sajith commented Sep 25, 2023

Fixes #110.

@sajith sajith self-assigned this Sep 25, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6306064215

  • 3 of 6 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 74.681%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sdx_datamodel/models/topology.py 3 6 50.0%
Totals Coverage Status
Change from base Build 6050869867: 0.05%
Covered Lines: 1028
Relevant Lines: 1245
💛 - Coveralls

@sajith sajith merged commit 1a18311 into main Sep 26, 2023
11 checks passed
@sajith sajith deleted the 110.topology-typos branch September 26, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YufengXin YufengXin YufengXin approved these changes

Assignees

@sajith sajith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typos in topology?
3 participants
@sajith @coveralls @YufengXin