Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Port schema to 2.0.0 draft spec #107

Merged
merged 6 commits into from
Aug 19, 2023
Merged

Update Port schema to 2.0.0 draft spec #107

merged 6 commits into from
Aug 19, 2023

Conversation

sajith
Copy link
Member

@sajith sajith commented Aug 18, 2023 •
edited
Loading

Partially addresses #102:

  • Updates Port schema to include L2VPN services.
  • Adds some tests.

@coveralls
Copy link

coveralls commented Aug 18, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5907160581

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.635%
Totals Coverage Status
Change from base Build 5903842534: 0.0%
Covered Lines: 1029
Relevant Lines: 1247
💛 - Coveralls

@sajith sajith changed the title Add some schema validation tests for new port definitions Update Port schema to 2.0.0 spec Aug 18, 2023
@sajith sajith changed the title Update Port schema to 2.0.0 spec Update Port schema to 2.0.0 draft spec Aug 18, 2023
@sajith sajith marked this pull request as ready for review August 18, 2023 21:25
@sajith sajith requested a review from YufengXin August 18, 2023 21:25
@sajith sajith merged commit 1a6404a into main Aug 19, 2023
6 checks passed
@sajith sajith deleted the 102.port-2.0.0-update branch August 19, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YufengXin YufengXin YufengXin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sajith @coveralls @YufengXin