refactor: remove unnecessary handling of isArray case #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
additionalProperties and additionalItems are allowed to be boolean or an object, never an array.
Note that additionalProperties defaults to true, hence why we're adding it as false here
derberg
changed the title
derberg
approved these changes
Apr 28, 2020
|
🎉 This PR is included in version 0.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the JSON Schema, and our parser (https://github.com/asyncapi/parser-js/blob/master/lib/models/schema.js#L195),
additionalPropertiesandadditionalItemsare allowed to be boolean or an object, never an array - and yet the HTML template handles this case.Can anyone confirm this, or have I misunderstood somewhere along the way?
Related issue(s)
I noticed this while exploring another issue (asyncapi/asyncapi-react#596), but wanted to sense check.