Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: new style guide - Grammar #781

Closed
wants to merge 8 commits into from

Conversation

Arya-Gupta
Copy link

@Arya-Gupta Arya-Gupta commented Jul 1, 2023

Issue: #1250

Description
Added style guide for Grammar:

  • Abbreviations and Acronyms
  • Active voice
  • Capitalization
  • Spelling
  • Verb tense

Related issue(s)
See #1343

Tagging @alequetzalli

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link
Contributor

@AnimeshKumar923 AnimeshKumar923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pinging @thulieblack for approval.

@AnimeshKumar923
Copy link
Contributor

/rtm

@asyncapi-bot
Copy link
Contributor

Hello, @AnimeshKumar923! 👋🏼
This PR is not up to date with the base branch and can't be merged.
Please update your branch manually with the latest version of the base branch.
PRO-TIP: Add a comment to your PR with the text: /au or /autoupdate and our bot will take care of updating the branch in the future. The only requirement for this to work is to enable Allow edits from maintainers option in your PR.
Thanks 😄

@AnimeshKumar923
Copy link
Contributor

/rtm

Was just checking how these commands work.

@asyncapi-bot
Copy link
Contributor

Hello, @AnimeshKumar923! 👋🏼
This PR is not up to date with the base branch and can't be merged.
Please update your branch manually with the latest version of the base branch.
PRO-TIP: Add a comment to your PR with the text: /au or /autoupdate and our bot will take care of updating the branch in the future. The only requirement for this to work is to enable Allow edits from maintainers option in your PR.
Thanks 😄

Signed-off-by: Arya Gupta <[email protected]>

Co-authored-by: V Thulisile Sibanda <[email protected]>
@octonawish-akcodes
Copy link
Contributor

Hi @Arya-Gupta can you mention the issue instead of the previous closed PR link?

Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Apr 11, 2024
@github-actions github-actions bot closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants