minor fix in notify slack step

asyncapi · Aug 10, 2023 · 2a15165 · 2a15165
1 parent 12bfdf7
commit 2a15165
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/maintainer_management.yml b/.github/workflows/maintainer_management.yml
@@ -257,8 +257,8 @@ jobs:
           gh pr create --title "docs(community): update latest emeritus list" --body "Updated Emeritus list is available and this PR introduces changes with latest information about Emeritus" --head update-emeritus-${{ github.run_id }}
 
   notify_slack_on_failure:
-    if: always() && (needs.detect_maintainer_changes.result == 'failure' || needs.add_maintainer.result == 'failure' || needs.display_message.result == 'failure' || needs.remove_maintainer.result == 'failure' || needs.update_emeritus.result == 'failure' || needs.remove_maintainer_goodbye.result == 'failure' )
-    needs: [detect_maintainer_changes, add_maintainer.result, display_message, remove_maintainer,remove_maintainer_goodbye, update_emeritus]
+    if: always() && (needs.detect_maintainer_changes.result == 'failure' || needs.add_maintainer.result == 'failure' || needs.display_message.result == 'failure' || needs.remove_maintainer.result == 'failure' || needs.update_emeritus.result == 'failure' || needs.remove_maintainer_goodbye.result == 'failure')
+    needs: [detect_maintainer_changes, add_maintainer, display_message, remove_maintainer, remove_maintainer_goodbye, update_emeritus]
     runs-on: ubuntu-latest
     steps:
     - name: Report workflow run status to Slack
@@ -267,4 +267,4 @@ jobs:
         SLACK_WEBHOOK: ${{secrets.SLACK_CI_FAIL_NOTIFY}}
         SLACK_TITLE: 🚨 Welcome new contributor action failed 🚨
         SLACK_MESSAGE: Failed to post a message to new Maintainer
-        MSG_MINIMAL: true
+        MSG_MINIMAL: true
diff --git a/.github/workflows/tsc_management.yml b/.github/workflows/tsc_management.yml
@@ -246,8 +246,8 @@ jobs:
           gh pr create --title "docs(community): update latest emeritus list" --body "Updated Emeritus list is available and this PR introduces changes with latest information about Emeritus" --head update-emeritus-${{ github.run_id }}
 
   notify_slack_on_failure:
-    if: always() && (needs.detect_tsc_membership_changes.result == 'failure' || needs. add_tsc_member.result == 'failure' || needs.display_message.result == 'failure' || needs.update_emeritus.result == 'failure' || needs.remove_tsc_member.result == 'failure' || needs.remove_tsc_goodbye.result == 'failure' || needs.remove_tsc_emeritus.result == 'failure' )
-    needs: [detect_tsc_membership_changes,  add_tsc_member.result, display_message, update_emeritus,remove_tsc_goodbye, remove_tsc_member, remove_tsc_emeritus]
+    if: always() && (needs.detect_tsc_membership_changes.result == 'failure' || needs.add_tsc_member.result == 'failure' || needs.display_message.result == 'failure' || needs.update_emeritus.result == 'failure' || needs.remove_tsc_member.result == 'failure' || needs.remove_tsc_goodbye.result == 'failure')
+    needs: [detect_tsc_membership_changes,  add_tsc_member, display_message, update_emeritus,remove_tsc_goodbye, remove_tsc_member]
     runs-on: ubuntu-latest
     steps:
     - name: Report workflow run status to Slack