Updates for Regions inputs #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larrybradley
force-pushed
the
regions-inputs
branch
from
8799ee2
to
bcd7767
Compare
pllim
reviewed
Sep 20, 2023
| @@ -24,7 +24,13 @@ class Regions: | |||
| The list of region objects. | |||
| """ | |||
|
|
|||
| def __init__(self, regions): | |||
| def __init__(self, regions=(), /): | |||
There was a problem hiding this comment.
It forces the input to be positional only. So Regions(regions=...) is not allowed. list does exactly the same thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
Regionsclass as follows:Regions()Regionsobject and itsappendandextendmethodsRegions.extendnow accepts aRegionsobjectCloses: #508
Closes: #509
Closes: #510
CC: @pllim