Add python38 and python310 targets #199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mckadesorensen
requested review from
mattp0,
gjclark,
lindsleycj and
mikedorfman
gjclark
reviewed
Aug 8, 2024
| ENV PYTHON_3_8_VERSION "3.8.16" | ||
| RUN \ | ||
| dnf groupinstall "Development Tools" -y && \ | ||
| dnf install openssl-devel bzip2-devel libffi-devel sqlite-devel -y && \ |
There was a problem hiding this comment.
Is it possible to pull out common stuff like dnf install openssl-devel bzip2-devel libffi-devel sqlite-devel -y && \ to not have repeat lines of code? I don't know the answer.
There was a problem hiding this comment.
Potentially. After what @mattp0 discovered + his recent changes, I think I am going to close this PR. This line in his changes FROM public.ecr.aws/lambda/python:3.9 as python3 makes me think these changes would probably not work well. I am keeping my CIRRUS-DAAC PR open, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some investigation, the issue in PR was caused by an ASF repo that our ingest was using.