-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match operations with permission objects with set operators #1
Conversation
- Also matches the initial premise on the permission objects.
- Have this class contain all the basic methods we need currently that are still needed by the Permission class.
- Can't just test one role...
- Allows the creation of permission objects that check for any of the nested permissions.
- Have the ``AndPermission`` similar to the ``OrPermission``.
- Done by testing that those singular bits of permission don't result in accessing of private bad data.
- Could keep them outside not behind those special override methods and have those call the actual implementation.
hey there @metatoaster I took a patch of your PR from forever ago and making my own fork here. I love the work you did and its disappointing the maintainer didnt merge your stuff. I think this repo could use alot more work as well. Hope you dont mind! |
Yeah by all means please do. I've done the same thing to other projects and if owner/maintainer disappeared or ignored everything I usually just end up forking the project, hand pick the patches and release it under a new name (with appropriate attribution and license, of course). |
ok cool! Just wanted to check with you since you actually wrote all the code haha. 5 year ago now? Your additions seem great and I think some people might be scared because of the bitwise but I think it's a great angle for this. |
Pulled from pallets-eco#21