Move btc wallet syncing in background #352
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, when the server starts on bitcoin chain, it waits for the blockchain scanner to fully sync with the blockchain.
Then, when the wallet is creates/restores/unlocked, again the server waits for the wallet to be fully in sync.
This adds changes so that the chain syncing is done in the background and until the wallet is not in sync and unlocked, the app service generating rounds is not even started.
This also adds safeguard check on all btc wallet apis to make sure the wallet is ready before doing anything and prevent panics.
Closes #349.
Please @louisinger @tiero review this.