-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK - Badger store, GetTransactionHistory & GetTransactionEventChannel #338
Open
sekulicd
wants to merge
6
commits into
ark-network:master
Choose a base branch
from
sekulicd:SDK-GetTransactionEventChannel-GetTransactionHistory
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SDK - Badger store, GetTransactionHistory & GetTransactionEventChannel #338
sekulicd
wants to merge
6
commits into
ark-network:master
from
sekulicd:SDK-GetTransactionEventChannel-GetTransactionHistory
Commits on Sep 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 13da10f - Browse repository at this point
Copy the full SHA 13da10fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1780958 - Browse repository at this point
Copy the full SHA 1780958View commit details
Commits on Sep 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c051640 - Browse repository at this point
Copy the full SHA c051640View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5056eee - Browse repository at this point
Copy the full SHA 5056eeeView commit details
Commits on Sep 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 61f0f1c - Browse repository at this point
Copy the full SHA 61f0f1cView commit details
Commits on Oct 3, 2024
-
This introduces a new feature to the ArkService API that allows clients to subscribe to payment events. Here's a breakdown of the changes: 1. **OpenAPI Specification (`service.swagger.json`):** - A new endpoint `/v1/payments` is added to the API, supporting a `GET` operation for streaming payment events. - New definitions `v1GetPaymentsStreamResponse`, `v1RoundPayment`, and `v1AsyncPayment` are added to describe the structure of the streaming responses. 2. **Protobuf Definition (`service.proto`):** - Added a new RPC method `GetPaymentsStream` that streams `GetPaymentsStreamResponse` messages. - Defined new message types: `GetPaymentsStreamRequest`, `GetPaymentsStreamResponse`, `RoundPayment`, and `AsyncPayment`. 3. **Generated Protobuf Code (`service.pb.go`, `service.pb.gw.go`, `service_grpc.pb.go`):** - The generated code is updated to include the new RPC method and message types. - The gateway code includes functions to handle HTTP requests and responses for the new streaming endpoint. 4. **Application Logic (`covenant.go`, `covenantless.go`):** - New payment events channels are introduced (`paymentEventsCh`). - Payment events are propagated to these channels when a round is finalized or an async payment is completed. - New event types `RoundPaymentEvent` and `AsyncPaymentEvent` are defined, implementing a `PaymentEvent` interface. 5. **gRPC Handlers (`arkservice.go`):** - Added logic to handle `GetPaymentsStream` requests and manage payment listeners. - A new goroutine is started to listen to payment events and forward them to active listeners. Overall, this patch extends the ArkService to support real-time streaming of payment events, allowing clients to receive updates on both round payments and async payments as they occur.
Configuration menu - View commit details
-
Copy full SHA for dfb9043 - Browse repository at this point
Copy the full SHA dfb9043View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.