Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): adjust transform origin in application-resource-tree component #20180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

srikanth597
Copy link

@srikanth597 srikanth597 commented Oct 1, 2024

Closes #19519

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@srikanth597 srikanth597 requested a review from a team as a code owner October 1, 2024 10:07
Copy link

bunnyshell bot commented Oct 1, 2024

❗ Preview Environment delete from Bunnyshell failed

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to try again to remove the environment

Copy link

bunnyshell bot commented Oct 1, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@srikanth597
Copy link
Author

Tested On a Regular device of 15-16 inches
image

@srikanth597
Copy link
Author

Tested on Monitor
image

Copy link
Contributor

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign the commits.

@srikanth597
Copy link
Author

Hi @nitishfy I am not sure if I have understood it correctly, but I have already signed the commits in the new PR, is that not correct?
image

@crenshaw-dev
Copy link
Member

crenshaw-dev commented Oct 1, 2024

@srikanth597 the naming is unfortunate. "Signed commits" are cryptographically signed (which you've done). "Signed-off commits" just have an extra bit of text on the commit message. You can check the details of the failed "DCO" check for instructions on how to sign off commits.

@nitishfy
Copy link
Contributor

nitishfy commented Oct 2, 2024

Hi @nitishfy I am not sure if I have understood it correctly, but I have already signed the commits in the new PR, is that not correct? image

Simply ammend it using git commit --amend --signoff command

@srikanth597 srikanth597 reopened this Oct 2, 2024
Copy link

bunnyshell bot commented Oct 2, 2024

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-qhpd5x.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-qhpd5x.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

bunnyshell bot commented Oct 2, 2024

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

See: Environment Details

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@srikanth597
Copy link
Author

@nitishfy i have cleared the DCO check

Copy link
Contributor

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Floating view toolbar covers cloud and first two resource boxes in Network View
3 participants