-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): adjust transform origin in application-resource-tree component #20180
base: master
Are you sure you want to change the base?
Conversation
❗ Preview Environment delete from Bunnyshell failedSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sign the commits.
Hi @nitishfy I am not sure if I have understood it correctly, but I have already signed the commits in the new PR, is that not correct? |
@srikanth597 the naming is unfortunate. "Signed commits" are cryptographically signed (which you've done). "Signed-off commits" just have an extra bit of text on the commit message. You can check the details of the failed "DCO" check for instructions on how to sign off commits. |
Simply ammend it using |
Signed-off-by: srikanth597 <[email protected]>
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
✅ Preview Environment created on Bunnyshell but will not be auto-deployedSee: Environment Details Available commands (reply to this comment):
|
@nitishfy i have cleared the DCO check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #19519
Checklist: