Remove Transaction Nif code #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package uses the Span API. The Transaction API isn't used anymore. Remove the C-extension and Nif code that still call it. Our deprecated Transaction API in Elixir is no-op and doesn't call these Nif functions so we can safely remove them. [skip changeset]
tombruijn
force-pushed
the
remove-unused-transaction-code
branch
from
10f5238
to
5787dac
Compare
unflxw
approved these changes
Sep 2, 2024
This is a message from the daily scheduled checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package uses the Span API. The Transaction API isn't used anymore. Remove the C-extension and Nif code that still call it. Our deprecated Transaction API in Elixir is no-op and doesn't call these Nif functions so we can safely remove them.
[skip changeset]