Follow @defoverridable protocol in Ecto repo
#959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our `Appsignal.Ecto.Repo`, which is meant to be a swap-in replacement for `Ecto.Repo`, should both call `super` on the original `Ecto.Repo` implementation of `default_options` that it overrides, and allow `super` to be called on it by modules that override `default_options`.
tombruijn
approved these changes
Aug 19, 2024
This comment has been minimized.
This comment has been minimized.
luismiramirez
approved these changes
Aug 20, 2024
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
jeffkreeftmeijer
approved these changes
Aug 22, 2024
|
This is a message from the daily scheduled checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this could be the cause of the issue fixed in #958, but I don't think it is anymore. Still, better to fix this corner case before it pokes someone.
Our
Appsignal.Ecto.Repo, which is meant to be a swap-in replacement forEcto.Repo, should both callsuperon the originalEcto.Repoimplementation ofdefault_optionsthat it overrides, and allowsuperto be called on it by modules that overridedefault_options.