Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend the Probe interface to support optional path, port and scheme properties #566

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Extend the Probe interface to support optional path, port and scheme properties #566

wants to merge 31 commits into from

Conversation

kabicin
Copy link
Collaborator

@kabicin kabicin commented Jul 25, 2023 •
edited
Loading

  • Create BaseComponentProbes interface so extending operators can override default settings for probes.
  • Create BaseComponentProbe wrapper to corev1.Probe
  • Create OptionalHTTPGetActions wrapper to HTTPGetActions to set path, port and scheme as optional.

Related issue OpenLiberty/open-liberty-operator#442

@kabicin kabicin marked this pull request as ready for review July 27, 2023 14:07
@kabicin kabicin mentioned this pull request Jul 27, 2023
Draft
@kabicin kabicin self-assigned this Jul 27, 2023
@kabicin kabicin changed the title Create BaseComponentProbes interface Extend the Probe interface to support optional port and scheme properties May 15, 2024
@kabicin kabicin mentioned this pull request May 16, 2024
Open
@kabicin kabicin changed the title Extend the Probe interface to support optional port and scheme properties Extend the Probe interface to support optional path, port and scheme properties May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kabicin kabicin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kabicin