Add sample module for Apigee Provisioning without VPC Peering #159
Conversation
baskaran-md
requested review from
danistrebel and
g-greatdevaks
as code owners
|
Thanks for the PR, Baskaran. |
There was a problem hiding this comment.
Thanks for the PR!
Definitely good to add the options to the core module. For the sample I would suggest maybe adding PSC + ILB setup or at least mentioning it in the README
The following would be needed in addition to the comments:
- simple test for the sample see for example the test for x-basic sample here https://github.com/apigee/terraform-modules/blob/main/tests/samples/test_x_basic.py
- re-create the docs for all modules with the script in ./tools/format-repo.sh
| @@ -36,9 +36,16 @@ variable "ax_region" { | |||
| type = string | |||
| } | |||
|
|
|||
| variable "disable_vpc_peering" { | |||
| description = "Flag that specifies whether the VPC Peering through Private Google Access should be disabled between the consumer network and Apigee." | |||
There was a problem hiding this comment.
Shouldn't this say through "Service Networking"? PGA is something different.
| type = bool | ||
| default = false | ||
| } | ||
|
|
||
| variable "network" { | ||
| description = "Network (self-link) to peer with the Apigee tennant project." |
There was a problem hiding this comment.
Can you also mention in the description that his isn't needed for the non-peering mode
| @@ -0,0 +1,80 @@ | |||
| # Basic Apigee X Setup without VPC Peering | |||
|
|
|||
| A minimal Apigee X setup without using VPC Peering. | |||
There was a problem hiding this comment.
Maybe worth adding a link to the docs or at least the release notes that explain this.
| @@ -0,0 +1,80 @@ | |||
| # Basic Apigee X Setup without VPC Peering | |||
There was a problem hiding this comment.
As the samples are meant to be somewhat self sufficient shouldn't this module also contain a northbound PSC component? Otherwise it could also just be a doc of setting networking to false in the x-core module.
Apigee announced the GA launch of its non-VPC provisioning option
Add sample modules for provisioning Apigee without VPC Peering.
apigee-x-coremodule.I tested the provisioning locally and is successful.
I have followed the relevant style guide for my changes.