YETUS-1233. 2023-09 Dependency Updates #311
Conversation
aw-was-here
force-pushed
the
2023-09-update
branch
from
c647ca4
to
261d784
Compare
|
|
||
| [filtering] | ||
| ignore= | ||
| http://localhost:8123/documentation/[0-9]+.[0-9]+.[0-9]+ |
There was a problem hiding this comment.
Why this ignore line? We don't want to check broken links on built documentation?
There was a problem hiding this comment.
It is specifically ignoring the references to previous release versions of the documentation which don't get built as part of this process but do sit on the web server.
| @@ -84,7 +84,6 @@ | |||
| </goals> | |||
| <configuration> | |||
| <executable>${rdm.bin}</executable> | |||
| <requiresOnline>true</requiresOnline> | |||
There was a problem hiding this comment.
oh why were these here in the first place?
There was a problem hiding this comment.
At some point in time, we either used a plugin that was offline/online aware or they removed the functionality from maven. But they were there so that you could tell maven you were offline and it wouldn't try to connect to JIRA to generate the release notes, etc.
| @@ -149,16 +149,22 @@ FROM yetusbase AS yetushadolint | |||
| ARG HADOLINT_VERSION=2.12.0 | |||
| SHELL ["/bin/bash", "-o", "pipefail", "-c"] | |||
| RUN if [[ "$(uname -m)" == "x86_64" ]]; then curl -sSL \ | |||
| https://github.com/hadolint/hadolint/releases/download/v$HADOLINT_VERSION/hadolint-Linux-"$(uname -m)" \ | |||
| https://github.com/hadolint/hadolint/releases/download/v$HADOLINT_VERSION/hadolint-Linux-x86_64 \ | |||
There was a problem hiding this comment.
I still prefer the style I proposed in my patch because docker can cache the downloaded artifacts between runs. The layer caching speeds up rebuild cycles drastically.
There was a problem hiding this comment.
I'm seeing it being cached here. 🤷
No description provided.