[SPARK-50669][SQL] Change the signature of TimestampAdd expression #49291
+96
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR the signature of
TimestampAdd
function was changed fromIntegerType
toLongType
for quantity parameter.Why are the changes needed?
To allow long types to be passed to timestamp_add function. Currently passing anything larger then
Int32.MaxValue
will cause a cast overflow exception. There is no need to restrict this method to only in32 values.Does this PR introduce any user-facing change?
Yes, the following query passes:
Above query now returns
2024-12-01T00:00:27.000+00:00
instead of throwing a cast exception.How was this patch tested?
New tests in this PR.
Was this patch authored or co-authored using generative AI tooling?
No