[SPARK-50662][PYTHON][WINDOWS] Escape ampersands in command arguments on windows #49286
+20
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for Windows compatibility
Nassizouz
force-pushed
the
escape-ampersand-on-windows
branch
from
302f4eb to
0b719a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Changing
java_gateway.pyand verious .cmd files so ampersands will be escaped using triple carets (^^^) on windows systemWhy are the changes needed?
On windows system, spark-submit is operated by running a chain .cmd files, this flow didn't handled ampersands (&) correctly so in each step, if the arguments that were passed to the next .cmd file/java contained an ampersand, the flags were truncated up to the location of the first ampersand
Does this PR introduce any user-facing change?
Yes
The previous behaviour couldn't handle configs with parameters, and the new one can
How was this patch tested?
This patch was tested on multiple windows machines across the company that work at
Was this patch authored or co-authored using generative AI tooling?
No