[SPARK-49087][SQL][CONNECT] Distinguish UnresolvedFunction calling internal functions #49274
+1,516
−751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xupefei
changed the title
HyukjinKwon
changed the title
…ql/internal/columnNodeSupport.scala
HyukjinKwon
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR introduces a new Protobuf field
is_internaltoUnresolvedFunctionmessage. This field is used to carry the info on whether anUnresolvedFunctionis calling an internal function (using theColumn#internalFnAPI), so that the Connect server could act appropriately:true, then (inside Catalyst) mark the function as internal.false, then mark the function as external (public or user-defined).TODO: SPARK-50658: apply the same change to the Spark Connect Python client.
Why are the changes needed?
Tidy up the code and make our first-party Connect client adhere to the best practices.
Does this PR introduce any user-facing change?
Nope.
How was this patch tested?
New test is added.
Was this patch authored or co-authored using generative AI tooling?
Copilot helped generate protobuf comments and repeated test codes.