Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DistSQLDatabaseRuleQueryExecutorAssert on ShowBroadcastTableRuleExecutorTest #33148

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Implement DistSQLDatabaseRuleQueryExecutorAssert on ShowBroadcastTableRuleExecutorTest #33148

wants to merge 4 commits into from
+134 −24

Conversation

ilyasahsan123
Copy link
Contributor

@ilyasahsan123 ilyasahsan123 commented Oct 7, 2024 •
edited
Loading

Fixes #33142.

Changes proposed in this pull request:

  • Use parameterized DistSQLDatabaseRuleQueryExecutorAssert to instead of DistSQLDatabaseRuleQueryExecutorTest

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@ilyasahsan123 ilyasahsan123 changed the title Use DistSQLDatabaseRuleQueryExecutorAssert instead of DistSQLDatabaseRuleQueryExecutorTest Implement DistSQLDatabaseRuleQueryExecutorAssert on ShowBroadcastTableRuleExecutorTest Oct 7, 2024
@ilyasahsan123
Copy link
Contributor Author

I’ve set this PR as fixes so I can create separate merge requests to complete task #33142.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use parameterized DistSQLDatabaseRuleQueryExecutorAssert to instead of DistSQLDatabaseRuleQueryExecutorTest
2 participants
@ilyasahsan123 @terrymanu