Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce new pitr subcommand delete #461

Merged
merged 13 commits into from
Nov 15, 2023
Merged

Conversation

mlycore
Copy link
Contributor

@mlycore mlycore commented Nov 15, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

#458

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

@github-actions github-actions bot added the pitr solutions of pitr label Nov 15, 2023
@mlycore mlycore added this to the 0.4.0 milestone Nov 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Attention: 942 lines in your changes are missing coverage. Please review.

Comparison is base (3604a24) 39.71% compared to head (49e8747) 36.71%.
Report is 193 commits behind head on main.

Files Patch % Lines
...phere-operator/pkg/controllers/chaos_controller.go 0.00% 276 Missing ⚠️
...rdingsphere-operator/pkg/kubernetes/pod/builder.go 0.00% 118 Missing ⚠️
...perator/pkg/controllers/storage_node_controller.go 26.58% 96 Missing and 20 partials ⚠️
...operator/pkg/controllers/auto_scaler_controller.go 0.00% 89 Missing ⚠️
pitr/cli/internal/cmd/delete.go 59.50% 38 Missing and 11 partials ⚠️
pitr/agent/internal/pkg/opengauss.go 2.70% 36 Missing ⚠️
...ator/cmd/shardingsphere-operator/manager/option.go 6.06% 31 Missing ⚠️
pitr/cli/internal/pkg/local-storage.go 3.22% 30 Missing ⚠️
...hardingsphere-operator/pkg/kubernetes/resources.go 0.00% 28 Missing ⚠️
...ere-operator/pkg/kubernetes/container/container.go 31.25% 22 Missing ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
- Coverage   39.71%   36.71%   -3.01%     
==========================================
  Files          51       61      +10     
  Lines        6083     6763     +680     
==========================================
+ Hits         2416     2483      +67     
- Misses       3448     4041     +593     
- Partials      219      239      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sandynz sandynz merged commit e2a5864 into apache:main Nov 15, 2023
8 checks passed
@mlycore mlycore deleted the cli-delete branch November 15, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pitr solutions of pitr type: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants