Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(operator): introduce PodBuilder and ShardingSphereDeploymentBuilder #428

Merged
merged 3 commits into from
Jul 5, 2023

Conversation

mlycore
Copy link
Contributor

@mlycore mlycore commented Jul 4, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Refactor

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?

@mlycore mlycore added this to the 0.3.0 milestone Jul 4, 2023
@github-actions github-actions bot added the operator solutions of operator label Jul 4, 2023
@mlycore mlycore added type: refactor in: computenode modules of computenode labels Jul 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Merging #428 (15844e0) into main (3604a24) will decrease coverage by 1.60%.
The diff coverage is 20.19%.

@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
- Coverage   39.71%   38.12%   -1.60%     
==========================================
  Files          51       53       +2     
  Lines        6083     6542     +459     
==========================================
+ Hits         2416     2494      +78     
- Misses       3448     3819     +371     
- Partials      219      229      +10     
Impacted Files Coverage Δ
pitr/agent/internal/handler/restore.go 0.00% <0.00%> (ø)
pitr/cli/internal/cmd/restore.go 58.33% <0.00%> (-0.99%) ⬇️
pitr/cli/internal/pkg/local-storage.go 40.65% <0.00%> (-2.09%) ⬇️
...tor/cmd/shardingsphere-operator/manager/manager.go 0.00% <0.00%> (ø)
...phere-operator/pkg/controllers/chaos_controller.go 0.00% <0.00%> (ø)
...rdingsphere-operator/pkg/kubernetes/pod/builder.go 0.00% <0.00%> (ø)
...gsphere-operator/pkg/kubernetes/service/builder.go 76.92% <ø> (ø)
...e-operator/pkg/reconcile/storagenode/aws/aurora.go 17.94% <0.00%> (-0.24%) ⬇️
...here-operator/pkg/reconcile/storagenode/aws/aws.go 0.00% <ø> (ø)
...erator/pkg/reconcile/storagenode/aws/rdscluster.go 0.00% <0.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.0% 1.0% Duplication

@tristaZero tristaZero merged commit 2e22000 into apache:main Jul 5, 2023
9 checks passed
@mlycore mlycore deleted the pod-fac branch July 5, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: computenode modules of computenode operator solutions of operator type: refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants