Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and merge duplicated fixtures #2325

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Conversation

terrymanu
Copy link
Member

No description provided.

@terrymanu terrymanu added the test label Oct 28, 2023
@terrymanu terrymanu added this to the 3.1.0 milestone Oct 28, 2023
@terrymanu terrymanu changed the title Remove duplicated fixture Remove duplicated fixtures Oct 28, 2023
@terrymanu terrymanu changed the title Remove duplicated fixtures Remove and merge duplicated fixtures Oct 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2023

Codecov Report

Merging #2325 (d1bd479) into master (f0c6852) will increase coverage by 0.59%.
Report is 42 commits behind head on master.
The diff coverage is 90.39%.

@@             Coverage Diff              @@
##             master    #2325      +/-   ##
============================================
+ Coverage     85.04%   85.63%   +0.59%     
+ Complexity     1237     1178      -59     
============================================
  Files           215      203      -12     
  Lines          3984     3823     -161     
  Branches        454      445       -9     
============================================
- Hits           3388     3274     -114     
+ Misses          390      350      -40     
+ Partials        206      199       -7     
Files Coverage Δ
...hardingsphere/elasticjob/api/JobConfiguration.java 72.00% <100.00%> (ø)
...lk/DingtalkJobErrorHandlerPropertiesValidator.java 100.00% <100.00%> (ø)
...email/EmailJobErrorHandlerPropertiesValidator.java 100.00% <100.00%> (ø)
...chat/WechatJobErrorHandlerPropertiesValidator.java 100.00% <100.00%> (ø)
...here/elasticjob/http/executor/HttpJobExecutor.java 95.91% <100.00%> (ø)
.../elasticjob/script/executor/ScriptJobExecutor.java 100.00% <ø> (ø)
.../elasticjob/simple/executor/SimpleJobExecutor.java 100.00% <ø> (ø)
...gsphere/elasticjob/tracing/JobTracingEventBus.java 96.15% <100.00%> (+0.50%) ⬆️
...e/elasticjob/tracing/api/TracingConfiguration.java 100.00% <ø> (ø)
.../elasticjob/tracing/event/JobStatusTraceEvent.java 0.00% <ø> (ø)
... and 73 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@taojintianxia taojintianxia merged commit fd93fa1 into apache:master Oct 28, 2023
12 checks passed
@terrymanu terrymanu deleted the dev branch October 28, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants