Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Jdbc] Support sink ddl for dameng #8380

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

hawk9821
Copy link
Contributor

Purpose of this pull request

#8127

Does this PR introduce any user-facing change?

How was this patch tested?

DmSchemaChangeIT

Check list

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @hailin0 and @dailai

@@ -29,6 +29,7 @@
public class AlterTableModifyColumnEvent extends AlterTableColumnEvent {
private final Column column;
private final boolean first;
private boolean typeChanged = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private boolean typeChanged = false;
private Boolean typeChanged;

Any default value is incorrect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants