Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][kafka] use config to set kafka deserialize error ignore parameter #8377

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

liunaijie
Copy link
Member

Purpose of this pull request

now, some desrialize use hardcode value to set the deserialize error ignore value.
actually we have this config, use config to set the value

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

boolean ignoreParseErrors =
readonlyConfig
.get(MESSAGE_FORMAT_ERROR_HANDLE_WAY_OPTION)
.equals(MessageFormatErrorHandleWay.SKIP);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is necessary to add some logging for this action, as it is a risky move

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some unit test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants