Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][API] Support timestamp with timezone offset #8367

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[Feature][API] Support timestamp with timezone offset #8367

wants to merge 1 commit into from

Conversation

hailin0
Copy link
Member

@hailin0 hailin0 commented Dec 23, 2024

Purpose of this pull request

[API] Support timestamp with timezone offset

Does this PR introduce any user-facing change?

No

How was this patch tested?

Added

Check list

@hailin0 hailin0 added the core SeaTunnel core module label Dec 24, 2024
@hailin0 hailin0 marked this pull request as ready for review December 24, 2024 08:13
Carl-Zhou-CN
Carl-Zhou-CN reviewed Dec 25, 2024
View reviewed changes
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/converter/BasicDataConverter.java
@@ -74,6 +74,8 @@ default Object convert(SeaTunnelDataType typeDefine, Object value) {
return convertTime(value);
case TIMESTAMP:
return convertLocalDateTime(value);
case TIMESTAMP_TZ:
return convertOffsetDateTime(value);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very interested in this. When can we make use of it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example：

mysql

datetime -> seatunnel timestamp
timestamp -> seatunnel timestamp_tz

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks for answering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carl-Zhou-CN Carl-Zhou-CN Carl-Zhou-CN left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
api connectors-v2 core SeaTunnel core module document e2e Spark
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hailin0 @Carl-Zhou-CN