[Feature][ClickhouseFile] Support avro file writer #8361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caicancai
force-pushed
the
avro_wirter
branch
from
b4e5f4f to
8f37e37
Compare
hailin0
reviewed
Dec 21, 2024
wuchunfu
reviewed
Dec 22, 2024
Comment on lines
-274
to
+244
| command.add("\"" + readerOption.getFileFieldsDelimiter() + "\""); | ||
| command.add(" --input-format Avro"); |
There was a problem hiding this comment.
@caicancai Can it be made optional here? For example, supporting CSV and AVRO, etc
There was a problem hiding this comment.
There are many bugs in csv format writing. From my experience, if you want to use csv, you must write a special parse for csv, such as rowconvertTocsv. I am not sure whether you still need to keep csv.
cc @Hisoka-X
@hailin0 I am not familiar with e2e testing. This may take some time. Do I really need to add e2e testing? |
Or upload a test screenshot, you need to prove that the modification is functional |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.