Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Connector-V2] Fix indefinite blocking by adjusting stopping condition in kafka split reader #8317

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

xiaochen-zhou
Copy link
Contributor

Purpose of this pull request

Fix indefinite blocking by adjusting stopping condition in split reader
refer: apache/flink-connector-kafka#100

Does this PR introduce any user-facing change?

no

How was this patch tested?

exist tests

Check list

@xiaochen-zhou xiaochen-zhou changed the title [Fix][Connector-v2] Fix indefinite blocking by adjusting stopping condition in split reader [Fix][Connector-V2] Fix indefinite blocking by adjusting stopping condition in split reader Dec 17, 2024
@xiaochen-zhou xiaochen-zhou changed the title [Fix][Connector-V2] Fix indefinite blocking by adjusting stopping condition in split reader [Fix][Connector-V2] Fix indefinite blocking by adjusting stopping condition in kafka split reader Dec 17, 2024
@Carl-Zhou-CN
Copy link
Member

Great catch! Can we also add test cases for this?

@xiaochen-zhou
Copy link
Contributor Author

Great catch! Can we also add test cases for this?

OK, I will try to add it.

@Carl-Zhou-CN
Copy link
Member

Great catch! Can we also add test cases for this?

OK, I will try to add it.

Looking forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants