[Improve] Remove deprecated code for MultipleRowTyp #8272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailin0
force-pushed
the
dev-remove-MultipleRowTyp
branch
from
ae961f8 to
aa15884
Compare
Hisoka-X
reviewed
Dec 18, 2024
| if (rowType instanceof SeaTunnelRowType) { | ||
| size = ((SeaTunnelRow) row).getBytesSize((SeaTunnelRowType) rowType); | ||
| } else if (rowType instanceof MultipleRowType) { | ||
| size = ((SeaTunnelRow) row).getBytesSize(rowTypeMap.get(tableId)); |
There was a problem hiding this comment.
we should use row type to init bytes size, it faster.
There was a problem hiding this comment.
SeaTunnelRow will cache the bytes size after init it. It will be used when record metrics in the next stage.
There was a problem hiding this comment.
You can use tableSchemas instead of rowType
hailin0
force-pushed
the
dev-remove-MultipleRowTyp
branch
from
6a4c5e2 to
f80f9d8
Compare
Hisoka-X
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
[Improve] Remove deprecated code for MultipleRowTyp
Does this PR introduce any user-facing change?
No
How was this patch tested?
Check list
New License Guide
release-note.