RATIS-1746. Change the shared byte array in SegmentedRaftLogWorker to be configurable. #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@szetszwo Thanks for the patch. I'd like to actually fix the leak. If we wanted to reduce the effect, we migth as well revert the shared buffer change (RATIS-1717). |
szetszwo
changed the title
@adoroszlai , The shared buffer change (RATIS-1717) is a good change. We should make it configurable. |
… be configurable.
szetszwo
changed the title
szetszwo
force-pushed
the
RATIS-1743_ByteArray
branch
from
78102d5 to
c40d234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/RATIS-1743Second attempt after #782See https://issues.apache.org/jira/browse/RATIS-1746